Should you upgrade? It really comes down to how much you want the new box. You've probably already overcome the wireless issues and you can expand your storage options via bolt-on hard drives. You'll really be doing so to reduce the noise.
The Xbox 360 S is a great refresh and one that Microsoft should be praised for.